Fix panic on system creation failure from db command #2872
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2867
I introduced the unfortunate typo was introduced on #2724 , prompted by the
shadow
vet tool: https://github.com/stellar/go/pull/2724/files#diff-dd30f3045790051170cd58e06c2667b6L185-R250shadow
is right in many cases but in this case it would had been fine, I wonder if we can tune the tool to avoid situations like this.