Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic on system creation failure from db command #2872

Merged
merged 1 commit into from
Jul 30, 2020
Merged

Fix panic on system creation failure from db command #2872

merged 1 commit into from
Jul 30, 2020

Conversation

2opremio
Copy link
Contributor

@2opremio 2opremio commented Jul 30, 2020 •
edited
Loading

Fixes #2867

I introduced the unfortunate typo was introduced on #2724 , prompted by the shadow vet tool: https://github.com/stellar/go/pull/2724/files#diff-dd30f3045790051170cd58e06c2667b6L185-R250

shadow is right in many cases but in this case it would had been fine, I wonder if we can tune the tool to avoid situations like this.

@2opremio 2opremio requested a review from a team July 30, 2020 19:08
@cla-bot cla-bot bot added the cla: yes label Jul 30, 2020
@2opremio 2opremio merged commit 43f14b3 into master Jul 30, 2020
@2opremio 2opremio deleted the 2867-fix-panic-on-system-creation-failure branch July 30, 2020 20:51
@2opremio 2opremio mentioned this pull request Aug 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamirms tamirms tamirms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Executing reingest command fails with a segmentation violation
2 participants
@2opremio @tamirms